Conversation
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Some small remarks, else LGTM.
Also would be nice if you add a quick screenshot with the change, for posterity :)
|
|
||
| <attr name="jumpToUnreadStyle" format="reference" /> | ||
|
|
||
| <style name="Widget.Vector.JumpToUnread.Base" parent="Widget.MaterialComponents.Chip.Action"> |
There was a problem hiding this comment.
I would have called this style: Base.Widget.Vector.Chip.Action.JumpToUnread, but anyway it's OK like that :)
| <item name="snackbarButtonStyle">@style/Widget.Vector.SnackBar.Button</item> | ||
| <item name="snackbarTextViewStyle">@style/Widget.Vector.SnackBar.TextView</item> | ||
| <item name="actionModeStyle">@style/Widget.Vector.ActionMode</item> | ||
| <item name="jumpToUnreadStyle">@style/Widget.Vector.JumpToUnread.Dark</item> |
There was a problem hiding this comment.
This section is for the default style of the system Widget.
Maybe move this new style at the end of the theme declaration (after vctr_social_login_button_gitlab_style)
| <item name="snackbarButtonStyle">@style/Widget.Vector.SnackBar.Button</item> | ||
| <item name="snackbarTextViewStyle">@style/Widget.Vector.SnackBar.TextView</item> | ||
| <item name="actionModeStyle">@style/Widget.Vector.ActionMode</item> | ||
| <item name="jumpToUnreadStyle">@style/Widget.Vector.JumpToUnread.Light</item> |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
|
|
||
| <attr name="jumpToUnreadStyle" format="reference" /> |
There was a problem hiding this comment.
Can you rename to vctr_jump_to_unread_style to follow the current naming convention of custom attributes of this project?
| android:layout_width="0dp" | ||
| <com.google.android.material.chip.Chip | ||
| android:id="@+id/jumpToReadMarkerView" | ||
| style="?attr/jumpToUnreadStyle" |
| android:paddingBottom="12dp" | ||
| android:text="@string/room_jump_to_first_unread" | ||
| android:textColor="?colorOnPrimary" | ||
| app:drawableStartCompat="@drawable/arrow_up_circle" /> |
There was a problem hiding this comment.
This resource (5 png files!) can be removed too.
2 participants
Implements new design for Jump to unread.
Also quick fix some issues with his visibility not being refreshed correctly (its more a temporary solution waiting for reworking all that...)